Add opt-in/opt-out config knobs for /review-pr (auto-merge, auto-fix)#2
Open
pgherveou wants to merge 3 commits intoreplghost:mainfrom
Open
Add opt-in/opt-out config knobs for /review-pr (auto-merge, auto-fix)#2pgherveou wants to merge 3 commits intoreplghost:mainfrom
pgherveou wants to merge 3 commits intoreplghost:mainfrom
Conversation
Introduce `product-dev-skills.auto-merge` git config (default `false`) so the review pipeline stops after CI is green instead of running `gh pr merge`, letting users merge manually unless they explicitly opt in.
Introduce `product-dev-skills.auto-fix` git config (default `true`). When set to `false`, the pipeline presents review findings and stops: no edits, no push, no merge. Lets users get a review without having the assistant modify the PR.
pgherveou
changed the title
Default `auto-fix=false` so the pipeline still produces fixes and runs all local checks but stops before pushing, prompting the user to approve (push) or discard (revert). Setting `auto-fix=true` opts in to the previous push-without-prompting behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto-merge(defaultfalse) — when unset/false,/review-prreviews, fixes, pushes, and waits for CI but stops short ofgh pr merge. Set totrueto opt in to auto-merge after CI passes.auto-fix(defaultfalse) — when unset/false, the pipeline still produces fixes and runs all local checks, but stops before pushing to show the diff and ask whether to approve (push) or discard (git reset --hard+ exit). Set totrueto push fixes without prompting (the previous behavior).git config --get --type=bool product-dev-skills.<key>so the stricttrue/falsesemantics are unambiguous, and each gets aCRITICAL: Respect $AUTO_*=falsenote so the pipeline can't bypass them.INSTALL.mddocuments both settings with copy-pasteablegit configsnippets.Test plan
auto-merge=true+auto-fix=true→ existing review→fix→push→CI→merge flow.auto-mergeunset (orfalse) +auto-fix=true→ pipeline pushes fixes and waits for CI green, then stops without callinggh pr merge.auto-fixunset (orfalse) → pipeline produces fixes and runs local checks, then prompts; on approve it pushes, on discard it reverts and exits.auto-fix=falsein a watcher/non-interactive session → pipeline does not push; reports prepared fixes and exits without committing.INSTALL.mdcopy-pastes cleanly.